count response codes only once #150
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In general, when dealing with
buckets
, counts must be split overle
. But one metric,hubResponseCodes
, sums overcode
only, which ends up counting each request once per bucket they match, since buckets are "less than or equal" and not mutually exclusive, resulting in over-counting requests by ~15x (the number of buckets). I became suspicious when my deployment had ~3k steady 200 responses every 2 minutes with ~20 active users. The real number was ~180.sum of buckets over code (before this PR):
Sum of buckets over code, le, showing double count:
Sum of count over code (this PR), matches the
le=+inf
value above: